He doesn't have to deal in illegal merchandise in order to obtain money.
I believe that to be an “international dealer” would be a compliment to Spike, and the destruction of the merchandise would have had much more consequences (or any, for that matter) than him “holding the eggs for a friend”. Of course, he did it for money, and the friend wasn't a friend, at all, but international dealer?
The problem it was that the whole thing was written to bring Riley into the scene, in order for him to show Buffy the errors of her choices; it wasn't a conversation with her Wicca best friend, or her own reflection about what was happening, it was all-good, all perfect soldier Riley who made her break up with Spike...
And again, that's very curious that something like that happened on a show by Joss Whedon.